-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Improvement to "Welcome Page" check #5012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughTwo new backup verification functions are introduced: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used📓 Path-based instructions (2)wled00/**/*.cpp📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
wled00/**/!(html_*)*.h📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Files:
🧬 Code graph analysis (3)wled00/cfg.cpp (1)
wled00/fcn_declare.h (2)
wled00/wled.cpp (1)
🪛 Clang (14.0.6)wled00/fcn_declare.h[error] 30-30: unknown type name 'bool' (clang-diagnostic-error) 🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I want to overhaul the whole onboarding process, but this is definitely an improvement until then |
There are frequent questions on why the welcome page shows in AP or ETH mode. The current workaround is to change the wifi network name, which is not intuitive.
This PR adds a secondary condition: if the config backup exists, the welcome page is also skiped, meaning the config was saved at least once.
This can still be changed to an actual config parameter in the future if better control is needed.
Summary by CodeRabbit