ML-DSA Pure Cert Support#251
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #251
Scan targets checked: wolfclu-bugs, wolfclu-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
7b1ecb7 to
915636c
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #251
Scan targets checked: wolfclu-bugs, wolfclu-src
Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #251
Scan targets checked: wolfclu-bugs, wolfclu-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #251
Scan targets checked: wolfclu-bugs, wolfclu-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
| int csrIsCA = wolfSSL_X509_get_isCA(x509); | ||
| int ku = wolfSSL_X509_get_keyUsage(x509); | ||
|
|
||
| if (csrIsCA && caCert != NULL) { |
There was a problem hiding this comment.
🟠 [Medium] ML-DSA CA signing honors CSR-requested CA:TRUE / keyUsage · Certificate validation bypass
When an ML-DSA CA signs a CSR, cert->isCA and cert->keyUsage are taken directly from the requester's CSR via wolfSSL_X509_get_isCA/wolfSSL_X509_get_keyUsage. A CSR asserting basicConstraints CA:TRUE causes the CA to issue a CA-capable (sub-CA) certificate to the requester.
Fix: For CA-issued (non-self-signed) certs, set basicConstraints/keyUsage from CA policy/config rather than the CSR, defaulting to CA:FALSE.
Notes: