fix: dkms.conf WOLFSSL_ROOT passthrough and docs#17
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes DKMS build configuration to correctly pass WOLFSSL_ROOT (with a sensible default) and updates supported kernel version matching to include 8.x; also adds documentation for DKMS usage. Additionally, this PR introduces Beads/Dolt and Claude agent configuration files, which appears unrelated to the DKMS fixes described.
Changes:
- Update
dkms.confto passWOLFSSL_ROOTinto the DKMSmakeinvocation and extendBUILD_EXCLUSIVE_KERNELto match 8.x. - Document DKMS setup and the
/usr/src/wolfsslconvention (plus override) inREADME.md. - Add Beads/Dolt repo metadata, hooks, and Claude/agent configuration; update
.gitignoreaccordingly.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| kernel-src/dkms.conf | Passes WOLFSSL_ROOT into DKMS builds; expands supported kernel regex to 8.x. |
| README.md | Adds DKMS usage docs and documents WOLFSSL_ROOT override. |
| CLAUDE.md | Adds AI agent workflow/tooling instructions (Beads). |
| AGENTS.md | Adds agent instructions and repeats Beads integration guidance. |
| .gitignore | Ignores Dolt/Beads artifacts (but uses broad *.db). |
| .claude/settings.json | Adds Claude hooks to run bd prime automatically. |
| .beads/** | Adds Beads configuration, metadata, docs, hooks, and ignore patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pass WOLFSSL_ROOT to make so DKMS builds can find the wolfssl tree. Defaults to /usr/src/wolfssl; overridable via environment. Extend BUILD_EXCLUSIVE_KERNEL regex to cover kernel 8.x. Add DKMS usage section to README.md.
MarkAtwood
force-pushed
the
fix/dkms-wolfssl-root-kernel8
branch
from
6746714 to
8521b09
Compare
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
What is this kernel 8.x Claude speaks of? lol
MarkAtwood
changed the title
|
Addressed douzzer's feedback — dropped the premature kernel 8.x support. Also fixed WOLFSSL_ROOT quoting for paths with spaces and the trailing |
- Remove kernel 8.x from BUILD_EXCLUSIVE_KERNEL (doesn't exist yet) - Quote WOLFSSL_ROOT expansion for paths with spaces - Add trailing \. to 3.1x regex branch for consistency
MarkAtwood
force-pushed
the
fix/dkms-wolfssl-root-kernel8
branch
from
26c68ba to
791efe3
Compare
Summary
dkms.confMAKEcommand never passedWOLFSSL_ROOT, so DKMS builds always failed at link time. Now defaults to/usr/src/wolfssl; overridable via environment variable.BUILD_EXCLUSIVE_KERNELregex only matched kernels 3–7; extended to include 8.x.README.mddocumenting the/usr/src/wolfsslconvention and theWOLFSSL_ROOToverride.Test plan
dkms add kernel-src/with wolfssl at/usr/src/wolfssl— verify build succeedsWOLFSSL_ROOT=/custom/path dkms install wolfguard/<version>— verify override is respecteddkms statusreports module installed on a kernel 8.x system