Use size_t in wolfSSL_strnstr and reject negative indices in mp_get_digit#10138
Open
padelsbach wants to merge 1 commit intowolfSSL:masterfrom
Open
Use size_t in wolfSSL_strnstr and reject negative indices in mp_get_digit#10138padelsbach wants to merge 1 commit intowolfSSL:masterfrom
padelsbach wants to merge 1 commit intowolfSSL:masterfrom
Conversation
padelsbach
commented
Apr 6, 2026
Contributor
Author
|
jenkins retest this please |
SparkiDev
reviewed
Apr 9, 2026
padelsbach
force-pushed
the
cobalt-fixes-2026-04-06
branch
from
3873057 to
4db500b
Compare
dgarske
reviewed
Apr 9, 2026
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 2 total — 2 posted, 1 skipped
Posted findings
- [Medium] Incomplete type migration: parameter
nstillunsigned intwhiles2_lenis nowsize_t—wolfcrypt/src/wc_port.c:4268-4275 - [Medium] No test for negative index in
mp_get_digit
Skipped findings
- [Medium] No test for negative index in
mp_get_digit
Review generated by Skoll via openclaw
padelsbach
force-pushed
the
cobalt-fixes-2026-04-06
branch
from
4db500b to
b2c480e
Compare
Contributor
Author
|
addressed both comments from skoll |
dgarske
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd21539
Testing
Manual review
Checklist