Initialize certificate: default to SHA-1 when necessary#10173
Open
SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
Open
Initialize certificate: default to SHA-1 when necessary#10173SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
SparkiDev wants to merge 1 commit intowolfSSL:masterfrom
Conversation
|
The PR fixes the issue. Thank you! |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
dgarske
requested changes
Apr 9, 2026
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: REQUEST_CHANGES
Findings: 2 total — 2 posted, 0 skipped
Posted findings
- [Critical] Inverted preprocessor condition:
defined(NO_SHA)should be!defined(NO_SHA)—wolfcrypt/src/asn.c:24996 - [Medium] Test fallback to SHAwRSA/SHAwECDSA does not guard against NO_SHA —
wolfcrypt/test/test.c:24514-24515
Review generated by Skoll via openclaw
SparkiDev
force-pushed
the
init_cert_sha1
branch
from
83d21ff to
61120b7
Compare
Make SHA-1 with RSA signature type the last option. SHA-1 signatures are deprecated as weak.
SparkiDev
force-pushed
the
init_cert_sha1
branch
from
61120b7 to
ecd925f
Compare
dgarske
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make SHA-1 with RSA signature type the last option.
SHA-1 signatures are deprecated as weak.
Fixes #10078
Testing
Standard builds