Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Aligns wc_AesGcmDecryptFinal() authentication tag size validation with other GCM APIs by enforcing WOLFSSL_MIN_AUTH_TAG_SZ (default 12) instead of only rejecting zero-length tags.
Changes:
- Tighten
authTagSzvalidation inwc_AesGcmDecryptFinal()to reject tags smaller thanWOLFSSL_MIN_AUTH_TAG_SZ.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Please re-run the failed test |
Author
|
Please retry the failed test |
Contributor
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wc_AesGcmDecryptFinal() checks authTagSz == 0 to reject zero-length tags, but does not enforce authTagSz < WOLFSSL_MIN_AUTH_TAG_SZ (default 12). Every other GCM API surface enforces this minimum: wc_AesGcmEncrypt (line 10056), wc_AesGcmDecrypt (line 10786), and wc_AesGcmEncryptFinal (line 12477) all check authTagSz < WOLFSSL_MIN_AUTH_TAG_SZ.
Changes
This PR fixes the validation of authTagSz as like other GCM APIs.
Testing
./configure --enable-all