Add bwrap network namespace isolation to scripts with listening ports#10177
Open
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Add bwrap network namespace isolation to scripts with listening ports#10177julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Add NETWORK_UNSHARE_HELPER/bwrap wrapping to benchmark.test, openssl_srtp.test, and sniffer-gen.sh to isolate network namespaces and prevent port collisions when tests run concurrently. sniffer-gen.sh uses --cap-add ALL (like dtls.test) since it runs tcpdump. ocsp-stapling.test is excluded because it connects to external servers (login.live.com).
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds network namespace isolation to select test/scripts to avoid TCP/UDP port collisions when running concurrently, using either NETWORK_UNSHARE_HELPER or bubblewrap (bwrap).
Changes:
- Wrap
sniffer-gen.sh,openssl_srtp.test, andbenchmark.testwith network-namespace unsharing logic. - Use
bwrap --unshare-netas a fallback whenNETWORK_UNSHARE_HELPERis not provided. - Grant additional capabilities for
sniffer-gen.shto supporttcpdump.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scripts/sniffer-gen.sh | Adds wrapper to unshare network namespace (helper or bwrap), with elevated caps for packet capture. |
| scripts/openssl_srtp.test | Adds wrapper to unshare network namespace (helper or bwrap) before running the test. |
| scripts/benchmark.test | Adds wrapper to unshare network namespace (helper or bwrap) before running the benchmark. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add NETWORK_UNSHARE_HELPER/bwrap wrapping to benchmark.test,
openssl_srtp.test, and sniffer-gen.sh to isolate network namespaces and
prevent port collisions when tests run concurrently. sniffer-gen.sh uses
--cap-add ALL (like dtls.test) since it runs tcpdump. ocsp-stapling.test
is excluded because it connects to external servers (login.live.com).