Skip to content

Aes key wrap with padding#10718

Open
night1rider wants to merge 1 commit into
wolfSSL:masterfrom
night1rider:AES-Key-wrap_with_padding
Open

Aes key wrap with padding#10718
night1rider wants to merge 1 commit into
wolfSSL:masterfrom
night1rider:AES-Key-wrap_with_padding

Conversation

@night1rider

@night1rider night1rider commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Adding AES Key Wrapping with Padding: https://datatracker.ietf.org/doc/html/rfc5649, and callback functionality for it.

@night1rider night1rider self-assigned this Jun 17, 2026
@github-actions

github-actions Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown

MemBrowse Memory Report

gcc-arm-cortex-m4-pkcs7

  • FLASH: .text +64 B (+0.0%, 213,204 B / 262,144 B, total: 81% used)

linuxkm-pie

  • Data: __patchable_function_entries +32 B (+0.1%, 26,000 B)

linuxkm-standard

  • Data: __patchable_function_entries +16 B (+0.0%, 48,616 B)

stm32-sim-stm32h753

wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jun 18, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10718

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the AES-Key-wrap_with_padding branch from 5f44e5a to 41dcbab Compare June 18, 2026 17:26
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jun 18, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10718

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

@night1rider
night1rider force-pushed the AES-Key-wrap_with_padding branch from e16f3e5 to 4615932 Compare June 23, 2026 22:14
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jun 23, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10718

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

@night1rider
night1rider force-pushed the AES-Key-wrap_with_padding branch from 3736341 to 52ff6d1 Compare July 10, 2026 23:49
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 11, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10718

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 11, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10718

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 13, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10718

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 20, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10718

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 20, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10718

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

@night1rider
night1rider force-pushed the AES-Key-wrap_with_padding branch from a904ca7 to 95e7b5b Compare July 20, 2026 19:46
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot reviewed Jul 20, 2026
View reviewed changes

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10718

Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src

No new issues found in the changed files. ✅

@night1rider
Add AES key wrap with padding (RFC 5649) and crypto callback support
d67913e 
Adds wc_AesKeyWrap_Pad/wc_AesKeyUnWrap_Pad and their _ex variants plus crypto
callback dispatch, routing blocks through wc_AesEcb* so an ECB only callback works.
@night1rider
night1rider force-pushed the AES-Key-wrap_with_padding branch from 95e7b5b to d67913e Compare July 20, 2026 22:59
@night1rider

night1rider commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

jenkins retest this please

1 similar comment
@night1rider

night1rider commented Jul 22, 2026

Copy link
Copy Markdown
Contributor Author

jenkins retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@JacobBarthelmeh JacobBarthelmeh

@wolfSSL-Bot wolfSSL-Bot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@night1rider @wolfSSL-Fenrir-bot @JacobBarthelmeh @wolfSSL-Bot