internal.c: extract functions to make code cleaner#10841
Merged
Conversation
|
SparkiDev
force-pushed
the
extract_funcs_ssl_1
branch
from
5ac2cb8 to
d47fff1
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10841
Scan targets checked: wolfssl-bugs, wolfssl-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
SparkiDev
force-pushed
the
extract_funcs_ssl_1
branch
2 times, most recently
from
bebac71 to
9138119
Compare
dgarske
reviewed
Jul 6, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
Skoll Code Review
Scan type: reviewOverall recommendation: COMMENT
Findings: 2 total — 2 posted, 0 skipped
2 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [Info] New block scopes introduced solely to declare helper-return variables —
src/internal.c:7445-7449, 14615-14621, 14704-14708, 14713-14717, 14770-14774 - [Info] skipAddCA now set unconditionally before pending-CA helper call —
src/internal.c:17494-17499
Review generated by Skoll
dgarske
previously approved these changes
Jul 6, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
This refactor looks great. There is a few empty braces in the refactor. I did a function by function review and the refactor looks good.
SparkiDev
force-pushed
the
extract_funcs_ssl_1
branch
from
9138119 to
9918a11
Compare
dgarske
approved these changes
Jul 6, 2026
Contributor
Author
|
Jenkins: retest this please |
dgarske
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted to functions pieces of code from very long functions.
Testing
enable-all