Rust wrapper: fix rsa_oaep cfg probe for FIPS - #11514
Open
holtrop-wolfssl wants to merge 1 commit into
Open
holtrop-wolfssl wants to merge 1 commit into
holtrop-wolfssl wants to merge 1 commit into
Conversation
Fixes F-12236.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes address FIPS-renamed symbol detection without unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Fixes Rust RSA-OAEP feature detection for FIPS builds with renamed wolfCrypt symbols.
Changes:
- Centralizes standard-to-FIPS symbol mappings.
- Reuses mappings for alias generation and cfg probing.
- Escapes function names in generated regex patterns.
| File | Description |
|---|---|
wrapper/rust/wolfssl-wolfcrypt/build.rs |
Adds FIPS rename handling to symbol detection and alias generation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rust wrapper: fix rsa_oaep cfg probe for FIPS
Fixes F-12236.
Testing
How did you test?
Checklist