20251022-FIPS-armasm-autotools-fixup #9332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
previously approved these changes
Oct 22, 2025
…9284: in configure.ac, add BUILD_FIPS_V5_PLUS and BUILD_FIPS_V6_PLUS conditionals, and fix BUILD_FIPS_V6 conditional to match v6 only; in src/include.am, add LEGACY_ARMASM_foo and NEW_ARMASM_foo helper variables, restore pre-PR9284 armasm clauses, and add or update several FIPS gates as needed; add empty wolfcrypt/src/port/arm/{armv8-aes.c,armv8-sha256.c,armv8-sha512.c} to mollify autotools, and in wolfcrypt/src/include.am, restore them to EXTRA_DIST if FIPS v5 or v6.
…() rather than a series of ByteReverseWord32() to get WOLFSSL_USE_ALIGN.
douzzer
force-pushed
the
20251022-FIPS-armasm-autotools-fixup
branch
from
12c6cac to
3bd5a30
Compare
|
retest this please |
dgarske
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for autotools config around armasm AES/SHA refactor in #9284:
in
configure.ac, addBUILD_FIPS_V5_PLUSandBUILD_FIPS_V6_PLUSconditionals, and fixBUILD_FIPS_V6conditional to match v6 only;in
src/include.am, addLEGACY_ARMASM_fooandNEW_ARMASM_foohelper variables, restore pre-PR9284 armasm clauses, and add or update several FIPS gates as needed;add empty
wolfcrypt/src/port/arm/{armv8-aes.c,armv8-sha256.c,armv8-sha512.c}to mollify autotools, and inwolfcrypt/src/include.am, restore them toEXTRA_DISTif FIPS v5 or v6.wolfcrypt/src/sha256.c: inwc_Sha256HashBlock(), useByteReverseWords()rather than a series ofByteReverseWord32()to getWOLFSSL_USE_ALIGN..wolfssl_known_macro_extras: snip out a couple no-longer-needed extras.tested with
wolfssl-multi-test.sh ... check-source-text cross-aarch64-armasm-fips-140-3-v6-unittest-sanitizeradditional testing with
make-dist-clean-check quantum-safe-wolfssl-cross-aarch64-armasm-unittest-sanitizer cross-aarch64-armasm-fips-140-3-v6-unittest-sanitizer all-crypto-openssl-extra-coexist-fips-v5-pilot fips-140-3-v5-ready-optest-acvp-intelasm fips-140-3-v5-dev-all