Skip to content

Conversation

@gojimmypi
Copy link
Contributor

@gojimmypi gojimmypi commented Oct 23, 2025

Description

Adds alternative syntax for wc_RNG_GenerateBlock when NOT_COMPILED_IN is desired for Microsoft VC.

When compiling wolfBoot on Visual Studio 2022, the wolfcrypt-only mode encounters an error for the not-compiled-in wc_RNG_GenerateBlock() as MSVC apparently does not like the macro expansion syntax and instead gives an unintuitive error for example here:

ret = wc_RNG_GenerateBlock(rng, key->k, ED25519_KEY_SIZE);

claiming this error:

Severity	Code	Description	Project	File	Line	Suppression State	Details
Error	C2059	syntax error: '{'	wolfcrypt	C:\workspace\wolfBoot-gojimmypi\lib\wolfssl\wolfcrypt\src\ed25519.c	323		

Fixes zd# n/a

Testing

Manually tested in wolfBoot. only basic checks here:

./autogen.sh
./configure
make
make check  

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi
Copy link
Contributor Author

Jenkins retest this please.

For (unexplained) SHA failure:

SHA      test failed!
 error L=4416 i=0
 [fiducial line numbers: 10440 30097 49877 62828]

Note the Windows 6244 ACVP test failure may well be related to the RNG update herein; See #9204 that changed test order.

@dgarske dgarske assigned gojimmypi and unassigned gojimmypi and wolfSSL-Bot Oct 24, 2025
@gojimmypi gojimmypi marked this pull request as draft October 24, 2025 17:22
@gojimmypi gojimmypi requested a review from dgarske November 7, 2025 19:11
@gojimmypi gojimmypi added the For This Release Release version 5.8.4 label Nov 7, 2025
@gojimmypi gojimmypi marked this pull request as ready for review November 7, 2025 19:12
@dgarske dgarske merged commit 2c47675 into wolfSSL:master Nov 10, 2025
261 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.8.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants