fixed oss-fuzz warnings #9386
Open
fixed oss-fuzz warnings #9386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Retest this please Jenkins |
sebastian-carpenter
force-pushed
the
oss-fuzz-fix-442261624
branch
from
c1c5b07 to
7fdd177
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two distinct errors being thrown by this oss-fuzz issue: one for hmac, and another for aes.
The hmac issue is in SSL_hmac and occurs because it tries to use a sha256 digest size instead of a sha1 digest size. This happened because the server hello allowed a ciphersuite containing sha256 to be used.
The aes issue was not encountered after fixing the hmac problem. Since the issue seems to be related to SSLv3 it's currently less of a priority to debug.
Fixes oss-fuzz issue 442261624.
Testing
Using the oss-fuzz reproduction steps.
Ran a
make checkin wolfssl with the default configuration.Checklist