Skip to content

Conversation

@dgarske
Copy link
Contributor

@dgarske dgarske commented Nov 14, 2025

Description

Migrate wolfAsyncCrypt repo into wolfSSL proper

Testing

Intel QuickAssist 8970

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Nov 14, 2025
@devin-ai-integration
Copy link
Contributor

🛟 Devin Lifeguard found 5 likely issues in this PR

  • no-void-functions snippet snippet: Change each newly-added void function (e.g. wolfAsync_HardwareStop) to return an integer status code (0 on success, negative on error) and update all call-sites accordingly.
  • use-forcezero snippet: Replace the XMEMSET call that clears opData (and similar XMEMSETs clearing key or secret buffers) with ForceZero(opData, sizeof(*opData)) to guarantee secure zeroization.
  • check-all-return-codes snippet: Handle the status returned by NitroxCheckRequest() (e.g. if (ret != 0) return ret;) instead of casting it to void.
  • use-c-style-comments snippet: Replace the //osalLogLevelSet(8); line with /* osalLogLevelSet(8); */ (and any other // comments) to comply with the C-style comment rule.
  • free-allocated-memory snippet: Audit every XMALLOC/XREALLOC added in quickassist.c (and related free helpers) to ensure that, on every error or success path—including early goto exit labels and asynchronous callback completions—the corresponding memory is released via the appropriate *Free() helper, and add missing XFREE calls where any path is uncovered.

@dgarske
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants