Skip to content

Conversation

@SparkiDev
Copy link
Contributor

Description

Fixes for deriving secret for ML-KEM.

Testing

C and Intel ASM code.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

Fixes for deriving secret for ML-KEM.
@SparkiDev SparkiDev added the For This Release Release version 5.8.4 label Nov 17, 2025
@devin-ai-integration
Copy link
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • no-void-functions snippet snippet: Change the debug helpers to return an int (e.g., int print_polys(...) { … return 0; } and int print_data(...) { … return 0; }) and update any call-sites to handle the return value.

@SparkiDev
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@SparkiDev
Copy link
Contributor Author

retest this please

Copy link
Contributor

@lealem47 lealem47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to fix decapsulation issue

@lealem47 lealem47 removed their assignment Nov 17, 2025
@JacobBarthelmeh JacobBarthelmeh merged commit 2be7482 into wolfSSL:master Nov 17, 2025
267 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.8.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants