Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2n-tls/1.4.19 package update #25133

Closed
wants to merge 1 commit into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Jul 29, 2024

@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Jul 29, 2024
Copy link
Contributor

Package s2n-tls: Click to expand/collapse

Package s2n-tls:
Unchanged

Package s2n-tls-dev: Click to expand/collapse

Package s2n-tls-dev:
Unchanged

bincapz found differences: Click to expand/collapse

Moved: s2n-tls-dev/var/lib/db/sbom/s2n-tls-dev-1.4.18-r0.spdx.json -> /tmp/wolfictl-apk-1584496598/s2n-tls/var/lib/db/sbom/s2n-tls-1.4.19-r0.spdx.json (similarity: 0.91)

Moved: s2n-tls-dev/var/lib/db/sbom/s2n-tls-dev-1.4.18-r0.spdx.json -> /tmp/wolfictl-apk-1584496598/s2n-tls-dev/var/lib/db/sbom/s2n-tls-dev-1.4.19-r0.spdx.json (similarity: 0.99)

@@ -1,6 +1,6 @@
package:
name: s2n-tls
version: 1.4.18
version: 1.4.19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder why the expected commit hasn't changed in this PR 🤔

Copy link
Member

@philroche philroche Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tag was deleted upstream - see https://github.com/aws/s2n-tls/tags and issue aws/s2n-tls#4673 filed to track 1.4.19 build issues.

There is currently no diff in upstream between 1.4.18 and main - see aws/s2n-tls@main...v1.4.18

We should reject this PR and wait for the next bump

@@ -1,6 +1,6 @@
package:
name: s2n-tls
version: 1.4.18
version: 1.4.19
Copy link
Member

@philroche philroche Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tag was deleted upstream - see https://github.com/aws/s2n-tls/tags and issue aws/s2n-tls#4673 filed to track 1.4.19 build issues.

There is currently no diff in upstream between 1.4.18 and main - see aws/s2n-tls@main...v1.4.18

We should reject this PR and wait for the next bump

@rawlingsj rawlingsj closed this Aug 2, 2024
@octo-sts octo-sts bot deleted the wolfictl-cbace6e6-8cc7-4687-ac44-f954fe6fb698 branch August 3, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants