This repository was archived by the owner on Jul 28, 2024. It is now read-only.
[FRNT-438] rewite select with list and popover #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatinacher
suggested changes
May 31, 2021
Irinaristova
force-pushed
the
feat/FRNT-438-rewite-select-with-list-and-popover
branch
from
cdebeee to
b7586c5
Compare
Irinaristova
force-pushed
the
feat/FRNT-438-rewite-select-with-list-and-popover
branch
from
668ceb0 to
6cb2433
Compare
risenxxx
reviewed
Jul 16, 2021
Comment on lines
+10
to
+11
| onClick?: React.EventHandler<React.SyntheticEvent>; | ||
| role?: string; |
There was a problem hiding this comment.
suggestion: может стоит заменить на что-то вроде
type ListElementProps = React.HTMLAttributes<HTMLLIElement> & { /* our props */ }И все оставшиеся пропсы в итоге спредить в элемент
| focus?: boolean; | ||
| } | ||
|
|
||
| const UploadAreaBase: React.FC<UploadAreaProps & Priority> = ({ |
There was a problem hiding this comment.
thought: Может стоит это выносить в UploadAreaProps (через intersection)? Как минимум если будем экспортировать UploadAreaProps, будет не очень правильно с типами
| version "7.14.5" | ||
| resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.14.5.tgz#848d7b9f031caca9d0cd0af01b063f226f52d785" | ||
| integrity sha512-y3rlP+/G25OIX3mYKKIOlQRcqj7YgrvHxOLbVmyLJ9bPmi5ttvUmpydVjcFjZphOktWuA7ovbx91ECloWTfjIA== | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
nitpick(blocking): у тебя тут что-то осталось из конфликта)
| version "7.14.6" | ||
| resolved "https://registry.yarnpkg.com/@babel/parser/-/parser-7.14.6.tgz#d85cc68ca3cac84eae384c06f032921f5227f4b2" | ||
| integrity sha512-oG0ej7efjEXxb4UgE+klVx+3j4MVo+A2vCzm7OUN4CLo6WhQ+vSOD2yJ8m7B+DghObxtLxt3EfgMWpq+AsWehQ== | ||
| <<<<<<< HEAD |
| "@babel/helper-create-class-features-plugin" "^7.14.5" | ||
| "@babel/helper-plugin-utils" "^7.14.5" | ||
| "@babel/plugin-syntax-private-property-in-object" "^7.14.5" | ||
| <<<<<<< HEAD |
risenxxx
reviewed
Jul 20, 2021
| const camelCase = (string: string) => string.charAt(0).toLowerCase() + string.slice(1); | ||
|
|
||
| const hasHandler = (handler: Handler, key: string) => { | ||
| return Object.prototype.hasOwnProperty.call(handler, key); |
There was a problem hiding this comment.
Это для фикса возможной проблемы, что там не объект прилетит (вообще как бы практически не важно, но закрыть варнинг)
sergeysova
requested review from
risenxxx and
tatinacher
and removed request for
ainursharaev and
rchubarkin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.