-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows SSL #138
Windows SSL #138
Conversation
We can see it working in this test: https://github.com/woocommerce/qit-cli/actions/runs/8162261104 (Updated) What we do here is:
This logic only triggers when running on Windows. (I've used the "QIT Environment Test - Linux" workflow just to do my tests on this branch) |
@@ -0,0 +1,78 @@ | |||
name: QIT Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for adding in this test workflow!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for getting this in @Luc45! I ran some tests locally and things continued to work as expected on macOS.
PHP on Windows comes by default without a Certificate Authority file, which prevents it from making any network request to URLs with
https://
(or maybe, to only a few, as it seems it succeeds at https://google.com)This PR adds a fallback to use a CA file on Windows if a request fails.
I've opened a feature request on PHP asking for this to be fixed: php/php-src#13601
And also did some isolated tests on a dedicated repo.