Skip undefined environment variable values to prevent runtime exceptions#51
Open
rickkuilman wants to merge 3 commits into
Open
Skip undefined environment variable values to prevent runtime exceptions#51rickkuilman wants to merge 3 commits into
rickkuilman wants to merge 3 commits into
Conversation
Updates the ReadEnvironmentFile action to skip environment variables that have no value (e.g. `SENTRY_LARAVEL_DSN`) instead of throwing a RuntimeException. Also adds tests to verify that these variables are ignored and handled gracefully.
rickkuilman
changed the title
Author
|
The actual implementation is found in this commit: b388ced The rest of the file changes are code styling, since that was included in the package :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where environment variables without a value (e.g. SENTRY_LARAVEL_DSN without an = sign) would cause a RuntimeException when parsed, see: #22
What was changed
Updated the ReadEnvironmentFile action to safely skip undefined environment variable values.
Added tests to ensure:
How to test
.env.with-undefined-valuefile was used containing a key without a value:The test suite confirms that the parser handles this situation correctly.