feat(connd): use IPAccounting for systemd service data usage metrics#1214
Merged
Conversation
sky-mart
reviewed
May 19, 2026
| ) -> Result<HashMap<String, IpAccounting>> { | ||
| let mut ip_accountings = HashMap::new(); | ||
|
|
||
| for (unit, service) in systemd.loaded_services().await? { |
Contributor
There was a problem hiding this comment.
I believe you could have done it in a functional manner ;)
sky-mart
reviewed
May 19, 2026
|
|
||
| let mut services = Vec::with_capacity(units.len()); | ||
|
|
||
| for (name, _, _, _, _, _, object_path, _, _, _) in units { |
Contributor
There was a problem hiding this comment.
how about a comment about other parameters we ditch here?
sky-mart
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new
conndto count data usage per systemd service by leveraging theIPAccountingoptionmanual tests
do not merge
note
BPFon the pearl kernel