Skip to content

feat(gondor): cleanup gondor invocations#1241

Merged
sfikastheo merged 4 commits into
mainfrom
sfikas/move-gondor-to-supervisor
May 29, 2026
Merged

feat(gondor): cleanup gondor invocations#1241
sfikastheo merged 4 commits into
mainfrom
sfikas/move-gondor-to-supervisor

Conversation

@sfikastheo
Copy link
Copy Markdown
Contributor

@sfikastheo sfikastheo commented May 29, 2026

  • supervisor: instead of wrapping another python script, sanitizes the input, and exports it to systemd
  • orb-hil: instead of calling gondor, use zorb from the runner to query supervisor's job
  • update-agent: consume version_overwrite, if that is provided, overwrite /etc/os-release with that value.

The gondor binary will be removed from development builds, and be replaced by an alias to zorbquerying
supervisor.

This is a development feature to quickly allow developers to OTA to whatever they wish.
PR is spread upon commits touching the different crates separately

@sfikastheo sfikastheo requested a review from a team as a code owner May 29, 2026 14:30
@sfikastheo sfikastheo requested review from sky-mart and vmenge May 29, 2026 14:30
@sfikastheo sfikastheo force-pushed the sfikas/move-gondor-to-supervisor branch from 18e79aa to abf76f0 Compare May 29, 2026 14:31
@github-actions
Copy link
Copy Markdown

Found two concrete issues:

  • supervisor/src/tasks/zoci.rs:15: JSON requests without restart now default to false, so {"version":"to-main"} only exports the env var and never restarts worldcoin-update-agent.service. The old JSON default was restart, because no_restart defaulted to false. This silently breaks existing job/gondor JSON callers and should default restart to true or preserve no_restart compatibility.

  • hil/src/commands/ota/system.rs:89: this treats zorb exit status as OTA kickoff success, but zorb query prints Zenoh error replies/no-reply termination and still exits successfully. If supervisor fails SetEnvironment/RestartUnit, HIL will continue monitoring as if the update started. Please make the runner command fail on error replies or parse/assert the query result before returning the start timestamp.

Comment thread hil/src/commands/ota/system.rs
Comment thread supervisor/src/tasks/zoci.rs
Copy link
Copy Markdown
Contributor

@sky-mart sky-mart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current HIL tests still send the no_restart option, so when you update the binaries in orb-os, the OTA test is supposed to fail.

LGTM

@sfikastheo sfikastheo merged commit b04335c into main May 29, 2026
28 checks passed
@sfikastheo sfikastheo deleted the sfikas/move-gondor-to-supervisor branch May 29, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants