You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
supervisor: instead of wrapping another python script, sanitizes the input, and exports it to systemd
orb-hil: instead of calling gondor, use zorb from the runner to query supervisor's job
update-agent: consume version_overwrite, if that is provided, overwrite /etc/os-release with that value.
The gondor binary will be removed from development builds, and be replaced by an alias to zorbquerying supervisor.
This is a development feature to quickly allow developers to OTA to whatever they wish.
PR is spread upon commits touching the different crates separately
supervisor/src/tasks/zoci.rs:15: JSON requests without restart now default to false, so {"version":"to-main"} only exports the env var and never restarts worldcoin-update-agent.service. The old JSON default was restart, because no_restart defaulted to false. This silently breaks existing job/gondor JSON callers and should default restart to true or preserve no_restart compatibility.
hil/src/commands/ota/system.rs:89: this treats zorb exit status as OTA kickoff success, but zorb query prints Zenoh error replies/no-reply termination and still exits successfully. If supervisor fails SetEnvironment/RestartUnit, HIL will continue monitoring as if the update started. Please make the runner command fail on error replies or parse/assert the query result before returning the start timestamp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supervisor: instead of wrapping another python script, sanitizes the input, and exports it to systemdorb-hil: instead of calling gondor, usezorbfrom the runner to query supervisor's jobupdate-agent: consumeversion_overwrite, if that is provided, overwrite/etc/os-releasewith that value.The
gondorbinary will be removed fromdevelopmentbuilds, and be replaced by an alias tozorbqueryingsupervisor.This is a development feature to quickly allow developers to OTA to whatever they wish.
PR is spread upon commits touching the different crates separately