fix: pin the revision of a teeclave-trustzone-sdk crate - #1356
Open
alekseifedotov wants to merge 1 commit into
Open
fix: pin the revision of a teeclave-trustzone-sdk crate#1356alekseifedotov wants to merge 1 commit into
alekseifedotov wants to merge 1 commit into
Conversation
alekseifedotov
force-pushed
the
aleksei/fix-teechave-revision
branch
2 times, most recently
from
August 20, 2026 18:15
3f61dd8 to
a1b6ac9
Compare
|
alekseifedotov
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the git source of the optee-teec-sys crates.io patch to a specific commit in the TheButlah/teaclave-trustzone-sdk fork, reducing supply-chain risk from a moving branch reference.
Changes:
- Replaces a moving
branch = "tfh"patch with a fixedrev = "2b6ca05f8b38496c201cf635032dcce3cfedb3d7". - Adds an inline comment documenting why the revision is pinned.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alekseifedotov
force-pushed
the
aleksei/fix-teechave-revision
branch
from
August 20, 2026 18:18
a1b6ac9 to
c621d3a
Compare
|
No concrete issues found. The PR correctly pins |
crate 'teeclave-trustzone-sdk' uses 'tfh' branch on fork of an upstream project. Pin its 'rev' to protect from supply chain attacks.
alekseifedotov
force-pushed
the
aleksei/fix-teechave-revision
branch
from
August 21, 2026 16:36
c621d3a to
11ffe2c
Compare
|
No concrete correctness, security, or regression issues found. The manifest pins the intended commit, and |
AlexKaravaev
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crate
teeclave-trustzone-sdkusestfhbranch on fork of an upstream project. Pin its revision to protect from supply chain attacks.