feat: add boster-leds keep-on mode for mcu-util and set brightenss th… #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qbicz
reviewed
Apr 17, 2025
| { | ||
| Ok(CommonAckError::Success) => { | ||
| info!("LEDs disabled"); | ||
| info!("White/booster LEDs turned off"); |
Member
There was a problem hiding this comment.
so booster & white are the same LEDs on Diamond?
Contributor
Author
There was a problem hiding this comment.
Yes, I think just the naming is a bit confusing. In control-api we call them "white leds", it's the same leds. But also at the same time rgbleds can be just white.
Collaborator
|
@AlexKaravaev do we still need this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rough cli.
Also existing booster command in mcu-util was not working for me.