refactor(update-agent-loader): pass configuration in explicitly#650
Merged
Conversation
9cd6e99 to
ee6f1a3
Compare
ee6f1a3 to
f09f257
Compare
alekseifedotov
requested changes
Aug 21, 2025
alekseifedotov
approved these changes
Aug 21, 2025
f09f257 to
7d03ef8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes were made:
orb-prefix, as conventional in our workspaceConfigstruct which has afrom_envfunction, call this inmain, and pass this into the rest of the code to be explicit about configuration of the program (and make it more possible to test the code)build.rsas it both doesn't make sense to check target os and error (the code will already error if its platform specific) and was non-hermetic (randomly generates build-time compiled constants from a non-seeded RNG)