feat(hil): debug-board: list & read/write eeprom to set config #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure ftdi by writing into eeprom on debug board v1.1 this allows setting a serial number for debug board identification
fouge
changed the title
There was a problem hiding this comment.
Pull request overview
This PR refactors FTDI device management to support multiple debug boards and adds EEPROM configuration capabilities for the FT4232H chip on debug board v1.1. The key changes introduce clearer terminology distinguishing USB serial numbers from FTDI channel-specific serials, and add new commands for device enumeration and EEPROM programming.
- Refactored FTDI serial terminology with clear distinction between USB serial (physical device), FTDI serial (channel-specific), and description
- Added
ftdi list/read/writecommands for device enumeration and EEPROM operations - Updated button control and reboot commands to support the new device selection options
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| hil/src/main.rs | Added FtdiCmd to the command enum to expose new FTDI operations |
| hil/src/ftdi.rs | Added FtdiChannel enum, refactored FtdiId (SerialNumber→FtdiSerial), added detach_all_ftdi_kernel_drivers() helper, updated pin constants (RTS_PIN→DTR_PIN), improved destroy_helper serial comparison logic |
| hil/src/commands/ftdi.rs | New file implementing list, read, and write subcommands for FTDI device management and EEPROM operations |
| hil/src/commands/reboot.rs | Updated to use new FTDI terminology with --usb-serial, --ftdi-serial, --desc, and --channel options |
| hil/src/commands/button_ctrl.rs | Updated to use new FTDI terminology and added fallback logic for device selection |
| hil/src/commands/mod.rs | Exported new FtdiCmd module |
| hil/src/boot.rs | Updated pin constants (BUTTON_PIN→DTR_PIN, RECOVERY_PIN→CTS_PIN), added DEFAULT_CHANNEL constant, improved fallback logic |
| hil/README.md | Added documentation for FTDI EEPROM configuration workflow with examples |
| hil/Cargo.toml | Added serde dependency with derive feature for EEPROM data serialization |
| Cargo.lock | Updated with serde dependency for hil crate |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fouge
changed the title
fouge
force-pushed
the
fouge/orb-hil-ftdi-eeprom
branch
from
92210c4 to
c767ec7
Compare
Refactored FTDI serial terminology - Clear distinction between: - `--usb-serial` (physical USB device, e.g., FT7ABC12) - `--ftdi-serial` (channel-specific, e.g., FT7ABC12C) - `--desc` (e.g., FT4232H C) Added FtdiChannel enum with FromStr impl for parsing A/B/C/D Updated commands (button-ctrl, reboot, ftdi read/write) to use the new terminology Added `ftdi list` command to enumerate all FTDI devices/channels Fixed serial comparison in destroy_helper() to strip channel suffix when comparing with USB serial
fouge
force-pushed
the
fouge/orb-hil-ftdi-eeprom
branch
from
c767ec7 to
5c074b8
Compare
take into account pr review from copilot + other small improvements
all the related code is about the debug board with a hardcoded ftdi chip, so not generic enough to be called ftdi and work with all or most ftdi chips
fouge
force-pushed
the
fouge/orb-hil-ftdi-eeprom
branch
from
1eca248 to
60b3311
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
take into account pr review from copilot + other small improvements
fouge
changed the title
group channels by debug board (& usb serial) when multiple debug boards are connected
fouge
force-pushed
the
fouge/orb-hil-ftdi-eeprom
branch
from
cb940a4 to
9dd403e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure ftdi by writing into eeprom on debug board v1.1
this allows setting a serial number for debug board identification
Refactored FTDI serial terminology - Clear distinction between:
--usb-serial(physical USB device, e.g., FT7ABC12)--ftdi-serial(channel-specific, e.g., FT7ABC12C)--desc(e.g., FT4232H C)Added FtdiChannel enum with FromStr impl for parsing A/B/C/D
Updated commands (button-ctrl, reboot, ftdi read/write) to use the new
terminology
Added
ftdi listcommand to enumerate all FTDI devices/channelsFixed serial comparison in destroy_helper() to strip channel suffix
when comparing with USB serial