feat: Orin HIL OTAs #859
Merged
feat: Orin HIL OTAs #859
+132
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgalanis
force-pushed
the
chris/ota-hil
branch
from
4085194 to
931134a
Compare
sfikastheo
approved these changes
Dec 9, 2025
AlexKaravaev
approved these changes
Dec 9, 2025
Contributor
AlexKaravaev
left a comment
AlexKaravaev
left a comment
There was a problem hiding this comment.
lgtm, should be more stable
chrisgalanis
force-pushed
the
chris/ota-hil
branch
from
197198b to
9fe311c
Compare
fouge
reviewed
Dec 11, 2025
hil/src/commands/ota/mod.rs
Outdated
| info!("Overlays wiped successfully, rebooting device"); | ||
|
|
||
| system::reboot_orb(&session).await?; | ||
| reboot(false, None) |
Collaborator
There was a problem hiding this comment.
can we call this function hard_reboot_button to show that it's a long button press 🤔
i would prefer that the reboot_orb function work (and it should, otherwise it means we have a bug that should be fixed)
chrisgalanis
force-pushed
the
chris/ota-hil
branch
from
4f2b248 to
c17337e
Compare
chrisgalanis
force-pushed
the
chris/ota-hil
branch
from
d9fc91d to
0522779
Compare
AlexKaravaev
approved these changes
Dec 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the device reboot logic in the OTA command implementation to use a new, centralized
rebootfunction and improves error handling during the reboot process.Device reboot logic update:
system::reboot_orbcall with the newrebootfunction, providing a more consistent and maintainable approach for device reboots. (hil/src/commands/ota/mod.rs)rebootfunction and supporting modules, ensuring all dependencies for the updated reboot logic are included. (hil/src/commands/ota/mod.rs)Error handling improvements:
wrap_err_with, making failures easier to diagnose. (hil/src/commands/ota/mod.rs)