Skip to content

Handle Datadog telemetry client initialization errors gracefully #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ocheretovich wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle Datadog telemetry client initialization errors gracefully #882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion update-agent/core/src/telemetry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,16 @@ pub const NO_TAGS: &[&str] = &[];

fn init_datadog_client() -> Client {
let datadog_options = Options::default();
Client::new(datadog_options).unwrap()

match Client::new(datadog_options) {
Ok(client) => client,
Err(err) => {
tracing::error!(
"failed to initialize datadog telemetry client: {err:?}"
);
Client::disabled()
}
}
}

/// A trait for logging errors instead of propagating the error with `?`.
Expand Down