Skip to content

Fix #38 Images that should be pushed but not kept are now deleted #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ardesco
Copy link
Contributor

@Ardesco Ardesco commented Feb 16, 2016

There is no good way to share information between MOJO's so I've used a maven property to pass over a comma separated list of image IDs.

@wouterd
Copy link
Owner

wouterd commented Feb 16, 2016

Hi Mike,

Thanks for the PR. Actually, you can share state between Mojos, via the PluginContext.
See AbstractDockerMojo#obtainListFromPluginContext()

For the rest, this looks great. :)

@Ardesco
Copy link
Contributor Author

Ardesco commented Feb 16, 2016

Close, it's Mark :)

DOH! I've been looking at this the wrong way. I didn't push stuff up into the AbstractDockerMojo because I didn't want to cause a conflict between List<ImageBuildConfiguration> images in BuildImageMojo and List<ImageTagConfiguration> images in TagImageMojo.

What I should have done is just define a list in AbstractDockerMojo instead of loading the data I care about sharing into a property.

I'll refactor it on the train on the way home tonight.

@Ardesco
Copy link
Contributor Author

Ardesco commented Feb 16, 2016

All done now, let me know if there's anything else outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants