-
Notifications
You must be signed in to change notification settings - Fork 1
docs: explanation about sitemaps in headless WordPress #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @theodesp 🚀 🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the overview and the introduction of the problem. I like how each solution has clear pros and cons. The three solutions need a little work. 1 is new to me, I haven't heard of it before, have you seen others do this method? I'm open to it but seems a little strange. The three methods documented in the RFC #17 that we need to comer here are:
- Proxying the sitemap from the front end to the back end. - https://github.com/wpdecoupled/site/tree/main/src/routes/%5Bfile%3Dsitemap%5D
- Generating a sitemap from GraphQL content (you cover this with 2/3...but static VS SSR is not a "separate" method...just a different rendering strategy. - https://github.com/wpengine/faustjs.org/blob/main/src/pages/wp-sitemap.xml/index.jsx
- Fetching existing sitemaps and and parsing them into a new sitemap with any added framework routes (the current faust method)
@theodesp @moonmeister, the problem with the 2. approach (WPGraphQL) is that WPGraphQL returns maximum 100 node per page. If you set You can increase that limit but it may cause problems for the WP instances low on resources: https://www.wpgraphql.com/filters/graphql_connection_max_query_amount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking really close. just had a couple clarifying questions needed on some of the code examples
19073cd
closes #50