Skip to content

docs: explanation about sitemaps in headless WordPress #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Mar 26, 2025

closes #50

@theodesp theodesp requested a review from a team as a code owner March 26, 2025 14:47
colinmurphy
colinmurphy previously approved these changes Mar 26, 2025
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @theodesp 🚀 🚀 🚀

@colinmurphy colinmurphy requested a review from moonmeister March 27, 2025 10:10
Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the overview and the introduction of the problem. I like how each solution has clear pros and cons. The three solutions need a little work. 1 is new to me, I haven't heard of it before, have you seen others do this method? I'm open to it but seems a little strange. The three methods documented in the RFC #17 that we need to comer here are:

  1. Proxying the sitemap from the front end to the back end. - https://github.com/wpdecoupled/site/tree/main/src/routes/%5Bfile%3Dsitemap%5D
  2. Generating a sitemap from GraphQL content (you cover this with 2/3...but static VS SSR is not a "separate" method...just a different rendering strategy. - https://github.com/wpengine/faustjs.org/blob/main/src/pages/wp-sitemap.xml/index.jsx
  3. Fetching existing sitemaps and and parsing them into a new sitemap with any added framework routes (the current faust method)

@ahuseyn
Copy link
Member

ahuseyn commented Mar 31, 2025

@theodesp @moonmeister, the problem with the 2. approach (WPGraphQL) is that WPGraphQL returns maximum 100 node per page. If you set first: 1000 it will only return the first 100. Details: https://www.wpgraphql.com/docs/known-limitations#pagination-limits

You can increase that limit but it may cause problems for the WP instances low on resources: https://www.wpgraphql.com/filters/graphql_connection_max_query_amount

@colinmurphy colinmurphy requested a review from ahuseyn March 31, 2025 10:25
colinmurphy
colinmurphy previously approved these changes Mar 31, 2025
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

@whoami-pwd whoami-pwd self-requested a review March 31, 2025 15:07
whoami-pwd
whoami-pwd previously approved these changes Mar 31, 2025
Copy link
Contributor

@whoami-pwd whoami-pwd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ahuseyn
ahuseyn previously approved these changes Mar 31, 2025
Copy link
Member

@moonmeister moonmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking really close. just had a couple clarifying questions needed on some of the code examples

moonmeister
moonmeister previously approved these changes Apr 7, 2025
ahuseyn
ahuseyn previously approved these changes Apr 8, 2025
colinmurphy
colinmurphy previously approved these changes Apr 8, 2025
@theodesp theodesp dismissed stale reviews from ahuseyn and moonmeister via a54e0a1 April 8, 2025 12:33
@ahuseyn ahuseyn self-requested a review April 9, 2025 15:20
@theodesp theodesp added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit fa1ff82 Apr 10, 2025
1 check passed
@theodesp theodesp deleted the docs-explanation-sitemaps branch April 10, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs[explanation]: Overview of sitemaps in HWP
5 participants