Skip to content

chore: wp-env backport nextjs apollo filesystem routing #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2025
Merged

chore: wp-env backport nextjs apollo filesystem routing #135

merged 4 commits into from
Apr 10, 2025

Conversation

ahuseyn
Copy link
Member

@ahuseyn ahuseyn commented Apr 8, 2025

Description

Adds wp-env to nextjs apollo filesystem routing example

Related Issue

#120

Type of Change

  • 📄 Example update (no functional changes)
  • 📝 Documentation update

How Has This Been Tested?

Tested by following the instructions provided in README.

Checklist

  • I have read the CONTRIBUTING document
  • My code follows the project's coding standards
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been highlighted, merged or published

@ahuseyn ahuseyn requested a review from a team as a code owner April 8, 2025 13:15
@ahuseyn ahuseyn linked an issue Apr 8, 2025 that may be closed by this pull request
chore: wp-env backport for nextjs-pages-router/apollo-client-filesystem-routing #120
Closed
@ahuseyn ahuseyn mentioned this pull request Apr 8, 2025
Closed
@colinmurphy
Copy link
Member

@ahuseyn

Will review this today 🚀

@colinmurphy colinmurphy self-requested a review April 9, 2025 08:49
colinmurphy
colinmurphy approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@colinmurphy colinmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

@ahuseyn ahuseyn added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 56ebe4f Apr 10, 2025
1 check passed
@ahuseyn ahuseyn deleted the wp-env-backport-nextjs-apollo-filesystem-routing branch April 10, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theodesp theodesp theodesp approved these changes

@colinmurphy colinmurphy colinmurphy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: wp-env backport for nextjs-pages-router/apollo-client-filesystem-routing
3 participants
@ahuseyn @colinmurphy @theodesp