[oldcommands] Deprecate PIDWrappers, since they use deprecated interfaces (#3868)

Author: sciencewhiz

wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/pidwrappers/PIDAnalogAccelerometer.java

@@ -9,7 +9,13 @@
 import edu.wpi.first.wpilibj.PIDSource;
 import edu.wpi.first.wpilibj.PIDSourceType;
 
-/** Wrapper so that PIDSource is implemented for AnalogAccelerometer for old PIDController. */
+/**
+ * Wrapper so that PIDSource is implemented for AnalogAccelerometer for old PIDController.
+ *
+ * @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
+ *     wrapper.
+ */
+@Deprecated(since = "2022", forRemoval = true)
 public class PIDAnalogAccelerometer extends AnalogAccelerometer implements PIDSource {
   protected PIDSourceType m_pidSource = PIDSourceType.kDisplacement;
 

wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/pidwrappers/PIDAnalogGyro.java

@@ -9,7 +9,13 @@
 import edu.wpi.first.wpilibj.PIDSource;
 import edu.wpi.first.wpilibj.PIDSourceType;
 
-/** Wrapper so that PIDSource is implemented for AnalogGyro for old PIDController. */
+/**
+ * Wrapper so that PIDSource is implemented for AnalogGyro for old PIDController.
+ *
+ * @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
+ *     wrapper.
+ */
+@Deprecated(since = "2022", forRemoval = true)
 public class PIDAnalogGyro extends AnalogGyro implements PIDSource {
   private PIDSourceType m_pidSource = PIDSourceType.kDisplacement;
 

wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/pidwrappers/PIDAnalogInput.java

@@ -8,7 +8,13 @@
 import edu.wpi.first.wpilibj.PIDSource;
 import edu.wpi.first.wpilibj.PIDSourceType;
 
-/** Wrapper so that PIDSource is implemented for AnalogInput for old PIDController. */
+/**
+ * Wrapper so that PIDSource is implemented for AnalogInput for old PIDController.
+ *
+ * @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
+ *     wrapper.
+ */
+@Deprecated(since = "2022", forRemoval = true)
 public class PIDAnalogInput extends AnalogInput implements PIDSource {
   protected PIDSourceType m_pidSource = PIDSourceType.kDisplacement;
 

wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/pidwrappers/PIDAnalogPotentiometer.java

@@ -9,7 +9,13 @@
 import edu.wpi.first.wpilibj.PIDSource;
 import edu.wpi.first.wpilibj.PIDSourceType;
 
-/** Wrapper so that PIDSource is implemented for AnalogPotentiometer for old PIDController. */
+/**
+ * Wrapper so that PIDSource is implemented for AnalogPotentiometer for old PIDController.
+ *
+ * @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
+ *     wrapper.
+ */
+@Deprecated(since = "2022", forRemoval = true)
 public class PIDAnalogPotentiometer extends AnalogPotentiometer implements PIDSource {
   protected PIDSourceType m_pidSource = PIDSourceType.kDisplacement;
 

wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/pidwrappers/PIDEncoder.java

@@ -9,7 +9,13 @@
 import edu.wpi.first.wpilibj.PIDSource;
 import edu.wpi.first.wpilibj.PIDSourceType;
 
-/** Wrapper so that PIDSource is implemented for Encoder for old PIDController. */
+/**
+ * Wrapper so that PIDSource is implemented for Encoder for old PIDController.
+ *
+ * @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
+ *     wrapper.
+ */
+@Deprecated(since = "2022", forRemoval = true)
 public class PIDEncoder extends Encoder implements PIDSource {
   private PIDSourceType m_pidSource = PIDSourceType.kDisplacement;
 

wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/pidwrappers/PIDMotorController.java

@@ -9,7 +9,13 @@
 import edu.wpi.first.wpilibj.PIDOutput;
 import edu.wpi.first.wpilibj.motorcontrol.MotorController;
 
-/** Wrapper so that PIDOutput is implemented for MotorController for old PIDController. */
+/**
+ * Wrapper so that PIDOutput is implemented for MotorController for old PIDController.
+ *
+ * @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
+ *     wrapper.
+ */
+@Deprecated(since = "2022", forRemoval = true)
 public class PIDMotorController implements PIDOutput, MotorController, Sendable {
   private final MotorController m_motorController;
 

wpilibOldCommands/src/main/java/edu/wpi/first/wpilibj/pidwrappers/PIDUltrasonic.java

@@ -10,7 +10,13 @@
 import edu.wpi.first.wpilibj.PIDSourceType;
 import edu.wpi.first.wpilibj.Ultrasonic;
 
-/** Wrapper so that PIDSource is implemented for Ultrasonic for old PIDController. */
+/**
+ * Wrapper so that PIDSource is implemented for Ultrasonic for old PIDController.
+ *
+ * @deprecated Use {@link edu.wpi.first.math.controller.PIDController} which doesn't require this
+ *     wrapper.
+ */
+@Deprecated(since = "2022", forRemoval = true)
 public class PIDUltrasonic extends Ultrasonic implements PIDSource {
   protected PIDSourceType m_pidSource = PIDSourceType.kDisplacement;
 

wpilibOldCommands/src/main/native/include/frc/pidwrappers/PIDAnalogAccelerometer.h

@@ -12,8 +12,13 @@ namespace frc {
 /**
  * Wrapper so that PIDSource is implemented for AnalogAccelerometer for old
  * PIDController
+ *
+ * @deprecated Use frc2::PIDController class instead which doesn't require this
+ * wrapper.
  */
-class PIDAnalogAccelerometer : public PIDSource, public AnalogAccelerometer {
+class WPI_DEPRECATED("Use frc2::PIDController class instead.")
+    PIDAnalogAccelerometer : public PIDSource,
+                             public AnalogAccelerometer {
   using AnalogAccelerometer::AnalogAccelerometer;
 
  public:

wpilibOldCommands/src/main/native/include/frc/pidwrappers/PIDAnalogGyro.h

@@ -11,8 +11,13 @@ namespace frc {
 
 /**
  * Wrapper so that PIDSource is implemented for AnalogGyro for old PIDController
+ *
+ * @deprecated Use frc2::PIDController class instead which doesn't require this
+ * wrapper.
  */
-class PIDAnalogGyro : public PIDSource, public AnalogGyro {
+class WPI_DEPRECATED("Use frc2::PIDController class instead.") PIDAnalogGyro
+    : public PIDSource,
+      public AnalogGyro {
   using AnalogGyro::AnalogGyro;
 
  public:

wpilibOldCommands/src/main/native/include/frc/pidwrappers/PIDAnalogInput.h

@@ -12,8 +12,13 @@ namespace frc {
 /**
  * Wrapper so that PIDSource is implemented for AnalogInput for old
  * PIDController
+ *
+ * @deprecated Use frc2::PIDController class instead which doesn't require this
+ * wrapper.
  */
-class PIDAnalogInput : public PIDSource, public AnalogInput {
+class WPI_DEPRECATED("Use frc2::PIDController class instead.") PIDAnalogInput
+    : public PIDSource,
+      public AnalogInput {
   using AnalogInput::AnalogInput;
 
  public: