-
Notifications
You must be signed in to change notification settings - Fork 665
Description
Rationale
Currently, the generated protobuf Java classes are not prefixed with Protobuf. (For example, Geometry2d.) This can cause clutter in intellisense recommendations- Although this isn't an issue for WPILib VSCode, it is still an issue for IDEs and the Javadoc search.
In addition, this naming scheme would better match the nested classes (which have that naming scheme to avoid ambiguity with the original class).
Desired solution
One option is to rename the *.proto files to protobuf_*.proto. Alternatively, we could specify option java_outer_classname = "Protobuf..."; in every .proto file.
Both options seem acceptable to me, but we should pick one and be consistent. Here's some thoughts I had about the different options:
protobuf_*.proto:
.protoand.javafilenames are more consistent- Only one spot to rename (If we want to do that for some reason)
java_outer_classname: - The output location is fully specified by consecutive
java_packageandjava_outer_classnameoptions
Context
See #6518 (comment).