Refactor file generation logic #787
Merged
+522
−617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gold856
force-pushed
the
dedupe-file-generation
branch
3 times, most recently
from
79a9a36 to
6507ac9
Compare
Gold856
force-pushed
the
dedupe-file-generation
branch
from
e63975c to
a7140af
Compare
|
I made a new command template project and the packages were not replaced to match the project |
|
Retested against Rapid React Command Bot, Command template, Romi Command template, and Timed Robot for C++/Java. Tested the Command/class generation as well for C++/Java. All the files are in the right places and have their contents replaced when needed. |
|
I'm not qualified to comment on the code, but I was able to create projects, import projects (including replacements), and create command classes, which seems to be the stuff impacted by this PR. |
PeterJohnson
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the very verbose and repetitive Promise-based code that handled template creation across Java and C++ into a set of utility functions that use async/await. Since this was pulled from #772,
fs/promiseswas used, and I wanted to avoid using the async wrappers that we have, so I checked the Node version that was used for the version of the VS Code engine we specify and found out bumping to Node 14 was possible and hasfs/promises.