Skip to content

Add Apple App Attest Go module for ThunderID - #31

Merged
Malith-19 merged 1 commit into
wso2:mainfrom
Malith-19:add-app-attest-go-dependencies
Jul 16, 2026
Merged

Add Apple App Attest Go module for ThunderID#31
Malith-19 merged 1 commit into
wso2:mainfrom
Malith-19:add-app-attest-go-dependencies

Conversation

@Malith-19

@Malith-19 Malith-19 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Adds github.com/fxamacker/cbor/v2 to the Go dependency registry for ThunderID.

ThunderID's Apple App Attest attestation verifier decodes the CBOR-encoded attestation object produced by DCAppAttestService.attestKey on iOS clients. This promotes fxamacker/cbor/v2 from an indirect dependency (already present transitively via go-webauthn/webauthn) to a direct one, so it now needs a registry entry.

  • Module: github.com/fxamacker/cbor/v2
  • Version floor: >=v2.9.2 (the version already resolved in the module graph)
  • Scopes: identity-platform, thunderid (matching the Google Play Integrity modules added for the same attestation feature.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds github.com/fxamacker/cbor/v2 to the Go dependency registry with a minimum allowed version of v2.9.2. The entry restricts usage to the identity-platform and thunderid scopes.

Suggested reviewers: anugayan, yomalip, tharindu1st

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main change: adding the Apple App Attest-related Go dependency for ThunderID.
Description check ✅ Passed The description covers the dependency purpose, technical justification, version floor, and scopes.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Malith-19
Malith-19 merged commit 67d21b0 into wso2:main Jul 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants