Add Apple App Attest Go module for ThunderID - #31
Merged
Conversation
📝 WalkthroughWalkthroughAdds Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
darshanasbg
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
github.com/fxamacker/cbor/v2to the Go dependency registry for ThunderID.ThunderID's Apple App Attest attestation verifier decodes the CBOR-encoded attestation object produced by
DCAppAttestService.attestKeyon iOS clients. This promotesfxamacker/cbor/v2from an indirect dependency (already present transitively viago-webauthn/webauthn) to a direct one, so it now needs a registry entry.github.com/fxamacker/cbor/v2>=v2.9.2(the version already resolved in the module graph)identity-platform,thunderid(matching the Google Play Integrity modules added for the same attestation feature.