Skip to content

Change workflowManagementApiPort to int - #39

Merged
anuruddhal merged 1 commit into
wso2:mainfrom
rdulmina:workflow-support
Jul 31, 2026
Merged

Change workflowManagementApiPort to int#39
anuruddhal merged 1 commit into
wso2:mainfrom
rdulmina:workflow-support

Conversation

@rdulmina

Copy link
Copy Markdown
Contributor

Purpose

$title

@rdulmina
rdulmina requested a review from manuranga as a code owner July 30, 2026 11:38
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f4308ca-5054-44a2-bc16-62b5798a5c01

📥 Commits

Reviewing files that changed from the base of the PR and between 6411a68 and c93abf3.

📒 Files selected for processing (1)
  • ballerina/config.bal

📝 Walkthrough

Summary

  • Updated workflowManagementApiPort from string to int.
  • Preserved the default port value of 8234 while enabling integer-based configuration parsing and validation.

Walkthrough

The workflowManagementApiPort configuration declaration in ballerina/config.bal now uses the int type instead of string. Its default value remains 8234, changing the expected type during configuration loading and validation.

Suggested reviewers: manuranga

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The pull request description uses a placeholder template, and pre-merge checks currently support only a single description template. Provide a completed description using the supported pull request template so the change can be evaluated consistently.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: changing workflowManagementApiPort to an int.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rdulmina
rdulmina requested a review from anuruddhal July 30, 2026 11:39
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.01%. Comparing base (7855d1c) to head (c93abf3).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #39   +/-   ##
=========================================
  Coverage     41.01%   41.01%           
  Complexity       45       45           
=========================================
  Files             6        6           
  Lines           395      395           
  Branches         92       92           
=========================================
  Hits            162      162           
  Misses          199      199           
  Partials         34       34           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anuruddhal
anuruddhal merged commit 207f022 into wso2:main Jul 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants