Improve the group assigning section - #10569
Conversation
|
Warning Review limit reached
Next review available in: 43 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesGroup editor behavior
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@features/admin.users.v1/components/user-groups-edit.tsx`:
- Around line 229-232: Update handleCloseAddNewGroupModal to cancel the pending
debounced handleUnselectedListSearch invocation before resetting searchQuery and
closing the modal. If the modal-opening flow also resets state, apply the same
cancellation there to prevent stale searches from running after reopening.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro Plus
Run ID: e5697da5-29b5-4117-94f2-7cdf3447e389
📒 Files selected for processing (1)
features/admin.users.v1/components/user-groups-edit.tsx
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10569 +/- ##
=======================================
Coverage 72.91% 72.91%
=======================================
Files 470 470
Lines 71389 71389
Branches 448 448
=======================================
Hits 52053 52053
+ Misses 19043 19040 -3
- Partials 293 296 +3 🚀 New features to boost your workflow:
|
Issues fixed
1. Stale search filter persisted across modal reopens.
searchQuerywas not reset when the group modal was opened or closed, so adisplayName co <value>filter set in one session leaked into the next open — the user saw a filtered list without any query in the search box.handleOpenAddNewGroupModalandhandleCloseAddNewGroupModalnow resetsearchQuerytonull.2. Debounced search callback could fire after the modal unmounted.
handleUnselectedListSearchis adebounce(..., 1000)— if the user typed and then closed the modal within the debounce window, the pending call still ran and updatedsearchQueryon an unmounted component. A cleanupuseEffectnow cancels the debounced function on unmount.Related Issue