Update HTTP connector version - #1569
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughSummary
WalkthroughThe default HTTP connector dependency changes to Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/mi-language-server/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/SynapseLanguageService.java`:
- Around line 1285-1290: Update the connector existence check in
SynapseLanguageService so it only skips copying when mi-connector-http-1.0.0.zip
already exists. Do not treat other mi-connector-http-*.zip archives as a match;
ensure the exact target used by httpConnectorPath is checked so existing
projects receive the 1.0.0 connector.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 15c79746-9944-4d83-b85a-71a08712bd84
⛔ Files ignored due to path filters (1)
packages/mi-language-server/org.eclipse.lemminx/src/main/resources/org/eclipse/lemminx/connectors/mi-connector-http-1.0.0.zipis excluded by!**/*.zip
📒 Files selected for processing (13)
packages/mi-extension/src/util/onboardingUtils.tspackages/mi-language-server/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/SynapseLanguageService.javapackages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/ConnectionFinderTest.javapackages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/ConnectionHandlerTest.javapackages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/inbound/ConnectorInfoEndpointTest.javapackages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/loader/ConnectorLoaderTest.javapackages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/loader/ConnectorReaderTest.javapackages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/loader/NewDependentProjectConnectorLoaderTest.javapackages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/pom/parser/PomParserTest.javapackages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/resource/finder/LoadDependentResourcesTest.javapackages/mi-language-server/org.eclipse.lemminx/src/test/resources/synapse/connector/test_project/pom.xmlpackages/mi-language-server/org.eclipse.lemminx/src/test/resources/synapse/pom.parser/test_pom_parser/pom.xmlpackages/mi-language-server/org.eclipse.lemminx/src/test/resources/synapse/resource.finder/test_project/pom.xml
fedc907 to
af7b55a
Compare
$subject