Skip to content

Update HTTP connector version - #1569

Merged
ChinthakaJ98 merged 3 commits into
wso2:release-4.2.xfrom
ChinthakaJ98:http-update
Aug 10, 2026
Merged

Update HTTP connector version#1569
ChinthakaJ98 merged 3 commits into
wso2:release-4.2.xfrom
ChinthakaJ98:http-update

Conversation

@ChinthakaJ98

Copy link
Copy Markdown
Contributor

$subject

@ChinthakaJ98 ChinthakaJ98 added the Checks/Run LS Tests Force run LS tests label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8f91d75d-8155-478b-a9c5-e3cf35574a26

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Summary

  • Updated the HTTP connector version to 1.0.0 across onboarding templates, language server resources, dependency files, and test fixtures.
  • Updated connector test assertions and dependency definitions to expect HTTP connector version 1.0.0.
  • Updated dompurify and js-yaml dependency override versions.

Walkthrough

The default HTTP connector dependency changes to 1.0.0. The language server packages mi-connector-http-1.0.0.zip. Connector tests and test POM files update their fixtures and expected versions. PNPM overrides update js-yaml to 4.3.1 and dompurify to 3.4.13.

Suggested reviewers: rosensilva, kaumini

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only "$subject" and does not provide the required purpose, goals, approach, testing, security, or release information. Replace "$subject" with a complete description that follows the repository template and documents the change, testing, and related impact.
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary change: updating the HTTP connector version.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@packages/mi-language-server/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/SynapseLanguageService.java`:
- Around line 1285-1290: Update the connector existence check in
SynapseLanguageService so it only skips copying when mi-connector-http-1.0.0.zip
already exists. Do not treat other mi-connector-http-*.zip archives as a match;
ensure the exact target used by httpConnectorPath is checked so existing
projects receive the 1.0.0 connector.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 15c79746-9944-4d83-b85a-71a08712bd84

📥 Commits

Reviewing files that changed from the base of the PR and between 392c2a2 and fedc907.

⛔ Files ignored due to path filters (1)
  • packages/mi-language-server/org.eclipse.lemminx/src/main/resources/org/eclipse/lemminx/connectors/mi-connector-http-1.0.0.zip is excluded by !**/*.zip
📒 Files selected for processing (13)
  • packages/mi-extension/src/util/onboardingUtils.ts
  • packages/mi-language-server/org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/SynapseLanguageService.java
  • packages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/ConnectionFinderTest.java
  • packages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/ConnectionHandlerTest.java
  • packages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/inbound/ConnectorInfoEndpointTest.java
  • packages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/loader/ConnectorLoaderTest.java
  • packages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/loader/ConnectorReaderTest.java
  • packages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/connector/loader/NewDependentProjectConnectorLoaderTest.java
  • packages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/pom/parser/PomParserTest.java
  • packages/mi-language-server/org.eclipse.lemminx/src/test/java/org/eclipse/lemminx/synapse/resource/finder/LoadDependentResourcesTest.java
  • packages/mi-language-server/org.eclipse.lemminx/src/test/resources/synapse/connector/test_project/pom.xml
  • packages/mi-language-server/org.eclipse.lemminx/src/test/resources/synapse/pom.parser/test_pom_parser/pom.xml
  • packages/mi-language-server/org.eclipse.lemminx/src/test/resources/synapse/resource.finder/test_project/pom.xml

@ChinthakaJ98
ChinthakaJ98 merged commit 1681937 into wso2:release-4.2.x Aug 10, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Checks/Run LS Tests Force run LS tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants