Update bundled Jass API for Reforged 3 - #1308
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60a5136fa3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| constant itemtype ITEM_TYPE_EQUIPMENT = ConvertItemType(7) | ||
| constant itemtype ITEM_TYPE_UNKNOWN = ConvertItemType(8) | ||
| constant itemtype ITEM_TYPE_ANY = ConvertItemType(9) |
There was a problem hiding this comment.
When a testLua(true).executeProg() case uses these item-type constants, the harness loads src/test/resources/luaruntime/common.j.lua, which still defines ITEM_TYPE_UNKNOWN as 7 and ITEM_TYPE_ANY as 8 rather than the new 8 and 9 values. Such Lua executions therefore validate behavior against a stale API and can either fail valid Reforged 3 tests or silently exercise the wrong item type; the runtime dump (including the new equipment constant/types) needs to be updated with this declaration change.
AGENTS.md reference: AGENTS.md:L108-L110
Useful? React with 👍 / 👎.
| call SetOpCinematicAvailable( bj_CAMPAIGN_OFFSET_RH, available ) | ||
| call PlayCinematic( "IntroRE" ) | ||
| elseif (cinematicIndex == bj_CINEMATICINDEX_UFE) then | ||
| call SetEdCinematicAvailable( bj_CAMPAIGN_INDEX_RU, available ) |
There was a problem hiding this comment.
When SetCinematicAvailableBJ is called with bj_CINEMATICINDEX_UFE, this passes bj_CAMPAIGN_INDEX_RU (10), although the newly added Rebirth campaign mapping translates that campaign to bj_CAMPAIGN_OFFSET_RU (1), and the adjacent HFO branch likewise uses its offset. Consequently the ending cinematic is enabled for the wrong campaign identifier instead of the Rebirth Undead campaign.
Useful? React with 👍 / 👎.
1 participant
Updates the bundled common.j and blizzard.j declarations for Warcraft III Reforged 3.0, including the new handle types, constants, natives, and BJ wrappers. Validation: CompilationUnitTests, StdLibOwnTests, and OptimizerTests passed; make_for_userdir passed.