Make serde_yaml dependency optional #168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robjtede
reviewed
Jan 30, 2025
Comment on lines
17
to
19
| #[display("YAML error")] | ||
| #[cfg(feature = "yaml_spec")] | ||
| Yaml(serde_yaml::Error), |
There was a problem hiding this comment.
feature guarding enum variants is a no-go for me, i'll get this solved another way
There was a problem hiding this comment.
maintainer PR edits are not enabled, see #169 for suggested change
There was a problem hiding this comment.
Still open to feedback on the approach shown there. It's unfortunately to lose the I/O methods but I can't think of a good solution immediately, but fns can be added if we come up with something.
There was a problem hiding this comment.
Thanks for taking over, that's really appreciated. I do not have any better idea regarding to the error type than what's already implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for already removing the problematic
serde_ymldependency. I just went a step further and added a feature to allow to remove any yaml dependencies for these that don't need to handle the yaml format.Fixes #152