CA-420533: Only clear RestartVM guidance on up-to-date hosts #6782
+209
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangj
force-pushed
the
private/gangj/CA-420533
branch
from
c1edabb to
cff51af
Compare
During rolling pool upgrade (RPU), RestartVM guidance should only be cleared when a VM restarts on a host that has been updated to match the coordinator's software version. Previously, the guidance was cleared whenever a VM restarted, regardless of the host's update status. This commit ensures that RestartVM guidance persists until the VM restarts on an up-to-date host, this provides accurate feedback to administrators about which VMs still need restarting after RPU. Also adds unit tests covering 6 scenarios: * VM restart on updated vs old host (via xenopsd) * VM halt on updated vs old host (via force_state_reset) * Suspended VM resume on updated vs old host Signed-off-by: Gang Ji <[email protected]>
gangj
force-pushed
the
private/gangj/CA-420533
branch
from
cff51af to
ba48b75
Compare
minglumlu
reviewed
Dec 4, 2025
| remove_pending_guidance ~__context ~self ~value:`restart_device_model ; | ||
| remove_pending_guidance ~__context ~self ~value:`restart_vm | ||
| (* Only remove RestartVM guidance if host is up-to-date with coordinator *) | ||
| let resident_on = Db.VM.get_resident_on ~__context ~self in |
Member
There was a problem hiding this comment.
This is in the branch of "state = `Halted". If the VM can't start on a host whose running xapi version lower than the one on the coordinator, this will not be necessary.
Contributor
Author
There was a problem hiding this comment.
Yes, it is a great question!
After a VM is Halted on an up-to-date host, does it still required for it to be started on an up-to-date host to clear the RestartVM guidance?
I think it should be yes? Then we can't clear the RestartVM guidance here at all?
minglumlu
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During rolling pool upgrade (RPU), RestartVM guidance should only be cleared when a VM restarts on a host that has been updated to match the coordinator's software version. Previously, the guidance was cleared whenever a VM restarted, regardless of the host's update status.
This commit ensures that RestartVM guidance persists until the VM restarts on an up-to-date host, this provides accurate feedback to administrators about which VMs still need restarting after RPU.
Also adds unit tests covering 6 scenarios: