Add deeper srcset attribute support - #91
Open
ssddanbrown wants to merge 1 commit into
Open
Conversation
This adds WHATWG based parsing for srcset attributes so that values can be validated, and so the URIs used can be validated against HTMLPurifier rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In usage, I noticed that the library added support for srcset attributes, but currently just defines these as text.
These attributes can contain (and load content) from URLs, so I thought it'd be ideal to have proper parsing of srcset attributes to validate their format, while ensuring the URLs contained within follow configured HTMLPurifier URI rules.
This adds WHATWG-based parsing for srcset attributes so that values can be validated, and so the URIs used can be validated against HTMLPurifier rules.
All code had been manually written by me.
I've tried to ensure I'm following project conventions, but just let me know if changes need to be made.
I've added a range of tests in an attempt to ensure coverage and logic validity.