formula: add hannorein/rebound - #517
MeteorsLiu wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Reviewed the Formula selection, build, packaging, pkg-config metadata, and consumer-test contracts against LLAR main 9c062aa5c4b1724bfd30cb72f7e0bda136f9c078 and upstream tags through 5.1.1. A local default-version build and consumer run succeeded, but the installed metadata does not identify the selected release, so version-gated pkg-config consumers reject the default artifact.
| pc := pkgconfig.new( | ||
| name = "rebound", | ||
| description = "REBOUND N-body integrator", | ||
| version = "4.4.1", |
There was a problem hiding this comment.
[P1] Publish the selected source version in rebound.pc
This Formula applies from 4.4.1 through the current default 5.1.1, but every artifact writes Version: 4.4.1. With the default build, pkg-config --modversion rebound therefore reports 4.4.1, and both pkg-config --atleast-version=5.0 rebound and --exact-version=5.1.1 fail even though the installed library came from tag 5.1.1. Please derive the .pc version from the checked-out source (the release is recorded in src/rebound.c) or otherwise ensure each selected release publishes its actual version.
Summary
hannorein/reboundas an LLAR Formula from the pinned Conan Center4.4.1recipe.libreboundtarget through the LLAR Autotools helper and publish Conan’s shared library, completesrc/*.hheader set, GPL license, and relocatablerebound.pcmetadata.pthreadlink requirement; no direct dependencies, package options, or comparator are needed.Evidence
d034b32b3106d282c32f0a23314b5c6ba1b0fa69maps4.4.1to upstream tag4.4.1, commite3671e77b3f397ee9a817e4771fa278ebd48bffc, with matching archive SHA-2560ae7bdf20750cd0a83c4905a66c3cde211f09ac732ffb4cba9887e68aba5273b.4.4.1through default5.1.1. Root Makefile and library/header contract were checked across every tag in that range.Validation
4.4.1: fresh build and Conan-derived C consumer pass.4.4.1: repeated run passes the cache-hit consumer path.5.1.1build and consumer pass.4.4.1and5.1.1pass through LLAR main9c062aa5c4b1724bfd30cb72f7e0bda136f9c078in a Linux container.4.4.0is rejected belowfromVer; Darwin is rejected by the verified platform filter.rebound.pcpassespkg-config --validate; fullpkg-config --cflags --libs reboundoutput is used for metadata and consumer compilation.git diff --checkpasses.Closes #236