-
Notifications
You must be signed in to change notification settings - Fork 88
Fixed cmake generation without .git directory #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ForserX
wants to merge
17
commits into
xiph:main
Choose a base branch
from
ForserX:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic builds on Ubuntu and macOS hosts for Github's CI automation. Each builds with either GNU Autotools or the plain Makefile, and then builds the documentation. Based on similar code from libopusenc, borrowing steps from the ci scripts directory and .travis-ci.yml.
Needed for the Documentation Build step to work.
I believe this is the current spelling.
pkg-config isn't finding openssl, despite it supposedly being installed by homebrew. Add some diagnostics to try to understand what's happening.
Copy cmake config from the ogg project for ci coverage on github.
It makes sense to keep these two build types together since they share dependencies, but rename them so it's clear they're a build parallel to the cmake action.
Revert the `action.yml` rename and merge the cmake build steps in with the others so it can share the dependency installs.
The doxygen invocation complains about this tool not being available.
Earlier we had trouble with CMake 3.20, and reverting to 3.16 worked around the problem. However this version is no longer available in homebrew, so the `brew bundle` step is failing in github ci. Try installing the latest version instead. Currently that's CMake 3.22.1.
the `if` key doesn't require expression quoting, except when it does.
Make sure tags are available so OpusFilePackageVersion.cmake can find and set a package version string. By default github actions only fetches the target commit with --no-tags.
Something is failing, see if things have un-bitrotted since we last ran.
`openssl version` is returning 1.1.1m so hopefully the default will just work now.
ffb5210
to
ec63ede
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example error: