Refactor toolkit registry - #132
Merged
Merged
Conversation
windchargerj
marked this pull request as ready for review
August 18, 2026 02:34
windchargerj
force-pushed
the
pr/refactor/toolkit-registry
branch
from
August 18, 2026 02:36
79ea912 to
e9e6362
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolkit registrations and discovery results now have separate owners.
What Changed
ToolkitScannerfor host discovery, executable lookup, version probing, latest successful scan snapshots, and per-host failures.ToolkitRegistryfor registered toolkits and the default toolkit. It refreshes matching entries by physical location, updates availability, restores backends, and serializes persisted state.ToolkitManagernow coalesces concurrent scans, cancels a project's scan when the project closes, and exposes project-awarevisibleToolkits,registeredToolkits, andregisteredToolkitqueries.backendId, removes duplicate registrations at the same physical location, and preserves the default toolkit where possible.ToolkitChangedNotifier.The resulting state flow looks like this:
flowchart TB Hosts["Platform hosts"] --> Scanner["ToolkitScanner"] User["User registrations<br/>and default toolkit"] --> Registry["ToolkitRegistry"] Scanner -->|"latest scan snapshot"| Manager["ToolkitManager"] Registry -->|"registered state"| Manager Manager -->|"refresh by location<br/>and availability"| Registry Manager -->|"project-aware queries"| Consumers["Settings, wizard,<br/>run configurations, build,<br/>metadata actions"] Manager -->|"ToolkitListener"| Selectors["Live toolkit selectors"]The scanner observes installed hosts and executables, the registry owns the user's registrations and default choice, and the manager combines both into the project-aware state consumed by actions and selectors.
Why
Impact
Discovery updates availability without overwriting registrations. Consumers receive live, project-aware toolkit state while retaining the user's selection.