fix(cmake): Set correct c++ compiler and detect ninja for MinGW #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
24bit-xjkp
commented
Aug 27, 2024
24bit-xjkp
commented
- Set clang++ and g++ first since we use the first c++ compiler in the toolchain to build the package
- Try to detect ninja when use a toolchain without mingw
- see MinGW平台上cmake包编译问题 #5518
1. Set clang++ and g++ first since we use the first c++ compiler in the toolchain to build the package 2. Try to detect ninja when use a toolchain without mingw 3. see xmake-io#5518
waruqi
reviewed
Aug 27, 2024
| set_toolset("cc", "clang" .. suffix) | ||
| set_toolset("cxx", "clang" .. suffix, "clang++" .. suffix) | ||
| set_toolset("cxx", "clang++" .. suffix, "clang" .. suffix) |
waruqi
reviewed
Aug 27, 2024
| -- When we are using a standalone clang/gcc toolchain without mingw, try to detect ninja automatically. | ||
| -- see:https://github.com/xmake-io/xmake/issues/5518 | ||
| local mingw = package:build_getenv("mingw") or package:build_getenv("sdk") or "" | ||
| mingw = find_tool(mingw, {paths = mingw}) |
There was a problem hiding this comment.
怪怪的，目前 xmake f -p mingw 的约定就是强制使用 mingw 工具链，如果 mingw 都找不到，应该直接 break 报错 mingw not found 。。压根到不了这。。
而且 find_tool 里串传 mingw path 。。怎么能 find 的到
There was a problem hiding this comment.
主要是Windows用clang-cl和msvc，而cross又有好多包不支持，改包描述也是个大工程，就用了mingw平台
find_tool写错了，应该是mingw/bin下找mingw32-make.exe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.