Add missing Linux platform triples in autoconf tool. #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redbeanw44602
changed the title
waruqi
reviewed
Aug 31, 2024
| elseif package:is_plat("linux") then | ||
| local triples = | ||
| { | ||
| ["arm64-v8a"] = "aarch64-linux-gnu", |
There was a problem hiding this comment.
xmake/xmake/platforms/linux/xmake.lua
Line 24 in 47e72b2
linux 下面好像并没有叫 arm64 的处理器架构，只有 arm64-v8a。
waruqi
reviewed
Aug 31, 2024
| mips64el = "mips64el-linux-gnu", | ||
| loong64 = "loongarch64-linux-gnu" | ||
| } | ||
| table.insert(configs, "--host=" .. (triples[package:arch()] or triples.i386)) |
There was a problem hiding this comment.
看上面写的都是 i386 所以就写 i386 了，要不都改过来？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解决 #5530
第一次pr，有很多不懂的地方还望指点。😂
不知道 trybuild 里的写的对不对，package/tools 应该没有问题，测试过了。