Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulkansdk searching for mingw platform #5549

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Fix vulkansdk searching for mingw platform #5549

merged 2 commits into from
Aug 31, 2024

Conversation

yh-sb
Copy link
Contributor

@yh-sb yh-sb commented Aug 30, 2024

#5531

Fix vulkan-1.lib searching when platform is mingw.

@yh-sb yh-sb changed the title Fix vulkansdk searching for mingw platform #5531 Fix vulkansdk searching for mingw platform Aug 30, 2024
@@ -30,13 +30,14 @@ import("lib.detect.find_package")
function _find_vulkan_from_paths(paths, opt)
opt = opt or {}
local arch = opt.arch or config.arch() or os.arch()
local plat = opt.plat or config.get("plat") or os.host()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use config.plat()

@waruqi waruqi added this to the v2.9.5 milestone Aug 31, 2024
@waruqi waruqi merged commit 47e72b2 into xmake-io:dev Aug 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants