feat: namespace MCP tools under their YAML name field #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCP tools are now grouped under a single namespace instead of being registered flat. Access pattern changes from tools.get_current_time() to tools.time.get_current_time(). - MCPAdapter requires namespace parameter (breaking change) - _refresh_tools returns ONE Tool with MCP tools as callables - call_tool uses callable_name to identify the actual MCP tool - describe() now properly matches on callable_name - Updated docs with naming guidance (use 'web' not 'fetch') - Renamed fetch.yaml to name: web to avoid tools.fetch.fetch() Closes: py-code-mode-6y4
Add to_dict() methods to ToolParameter, ToolCallable, and Tool dataclasses
to provide proper JSON serialization. Update list_tools() and search_tools()
in all executors to use to_dict() for consistent output.
Before: {'name': 'curl', 'description': '...', 'tags': []}
After: {'name': 'curl', 'description': '...', 'tags': [], 'callables': [...]}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
name:field) instead of flat registrationtools.time.get_current_time()instead oftools.get_current_time()MCPAdapterrequiresnamespaceparameterChanges
MCPAdapter.__init__,connect_stdio,connect_sserequirenamespace: str_refresh_toolsreturns ONE Tool with all MCP tools as callablescall_toolusescallable_nameto identify the actual MCP tooldescribe()now properly matches oncallable_namewebnotfetch)fetch.yamltoname: webto avoidtools.fetch.fetch()Testing
Closes: py-code-mode-6y4