Skip to content

Conversation

@xpcmdshell
Copy link
Owner

@xpcmdshell xpcmdshell commented Jan 18, 2026

Consolidated code review fixes:

  • Workflows: reject run() signatures that declare namespace globals (tools, workflows, artifacts, deps); workflows access these via globals.
  • ContainerExecutor: when auth_disabled=True, bind the published port to 127.0.0.1 to avoid accidental LAN exposure.
  • HTTPAdapter: add a default request timeout (30s) and URL-encode path parameters.
  • Error handling: stop silent fallbacks (raise on Redis vector search errors; container /api/workflows* endpoints return 503 if the library failed to initialize).

Tests:

  • uv run ruff format .
  • uv run ruff check .
  • uv run mypy src/
  • uv run pytest

@xpcmdshell xpcmdshell merged commit f7287e7 into main Jan 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants