XWIKI-20436: bootstrap .btn:hover can result in white text on white background for buttons #4673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackground for buttons * Added standard classes to the notification buttons * Removed some unecessary custom CSS * Cleaned up a bit the leftover CSS, replacing oldColortheme values with their recent counterpart CSS Flamingo theme values :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-20436
Changes
Description
Screenshots & Video
Here are a few colorThemes/iconTheme combinations with the changes applied.
The standard Iceberg colors for default buttons have been swapped around.
We can see on those screenshots that the buttons now follow the expected colors and are not hard-coded to their own thing anymore.
Executed Tests
Manual tests, see screeshots above.
Built the changes with
mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-macro/xwiki-platform-notifications-macro-ui -Pqualityandmvn clean install -f xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates -Pquality. Succesfully passed the docker tests:mvn clean install -f xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-test/xwiki-platform-notifications-test-dockerChecked with SonarQube analysis, nothing to report.
Expected merging strategy